]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
rtc: tps6586x: Use IRQ_NOAUTOEN flag
authorDmitry Osipenko <digetx@gmail.com>
Mon, 6 Jan 2020 01:56:15 +0000 (04:56 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 25 Jan 2020 20:50:18 +0000 (21:50 +0100)
The IRQ_NOAUTOEN flag tells interrupt core that interrupt shall not be
auto-enabled at the time of requesting interrupt. This is a minor clean-up
change that doesn't fix any problems.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/20200106015615.12602-1-digetx@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-tps6586x.c

index 859d901fa6cbb3802683078c1899f256dd99db22..e39af2d670510ff0de46c09ed114f77cc84ca96e 100644 (file)
@@ -23,6 +23,7 @@
 #include <linux/device.h>
 #include <linux/err.h>
 #include <linux/init.h>
+#include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/mfd/tps6586x.h>
 #include <linux/module.h>
@@ -267,6 +268,8 @@ static int tps6586x_rtc_probe(struct platform_device *pdev)
        rtc->rtc->start_secs = mktime64(2009, 1, 1, 0, 0, 0);
        rtc->rtc->set_start_time = true;
 
+       irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN);
+
        ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
                                tps6586x_rtc_irq,
                                IRQF_ONESHOT,
@@ -276,7 +279,6 @@ static int tps6586x_rtc_probe(struct platform_device *pdev)
                                rtc->irq, ret);
                goto fail_rtc_register;
        }
-       disable_irq(rtc->irq);
 
        ret = rtc_register_device(rtc->rtc);
        if (ret)