]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm: rcar-du: Fix the return value in case of error in 'rcar_du_crtc_set_crc_source()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 16 Oct 2018 06:58:25 +0000 (08:58 +0200)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fri, 23 Nov 2018 11:51:22 +0000 (13:51 +0200)
We return 0 unconditionally in 'rcar_du_crtc_set_crc_source()'.
However, 'ret' is set to some error codes if some function calls fail.

Return 'ret' instead to propagate the error code.

Fixes: 47a52d024e89 ("media: drm: rcar-du: Add support for CRC computation")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
drivers/gpu/drm/rcar-du/rcar_du_crtc.c

index 7406ffd1ab944c1b3439ca9c0518ad1994d2c6d3..d18a342626b52075f1cb35b7f5ed65d646e87d7d 100644 (file)
@@ -1002,7 +1002,7 @@ static int rcar_du_crtc_set_crc_source(struct drm_crtc *crtc,
        drm_modeset_drop_locks(&ctx);
        drm_modeset_acquire_fini(&ctx);
 
-       return 0;
+       return ret;
 }
 
 static const struct drm_crtc_funcs crtc_funcs_gen2 = {