]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Input: nomadik-ske-keypad - fix a loop timeout test
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 21 Dec 2018 08:38:30 +0000 (00:38 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 21 Dec 2018 08:52:37 +0000 (00:52 -0800)
The loop exits with "timeout" set to -1 not to 0.

Fixes: 1158f0f16224 ("Input: add support for Nomadik SKE keypad controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/nomadik-ske-keypad.c

index 8567ee47761e111b31f7c8270bdc6414de6668a1..ae3b04557074010bc708c48db877c486f9d1cd0a 100644 (file)
@@ -100,7 +100,7 @@ static int __init ske_keypad_chip_init(struct ske_keypad *keypad)
        while ((readl(keypad->reg_base + SKE_RIS) != 0x00000000) && timeout--)
                cpu_relax();
 
-       if (!timeout)
+       if (timeout == -1)
                return -EINVAL;
 
        /*