]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mtd: rawnand: denali: fix probe function error path
authorMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 21 Mar 2018 13:01:45 +0000 (14:01 +0100)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Thu, 29 Mar 2018 07:38:19 +0000 (09:38 +0200)
An error after nand_scan_tail() should trigger a nand_cleanup().
The helper mtd_device_register() returns an error code that should
be checked and nand_cleanup() called accordingly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/mtd/nand/raw/denali.c

index 313c7f50621bf71b94a4e54a91b016cf887b6619..2a302a1d1430de0ef0a7e815fae42007f59e8f4d 100644 (file)
@@ -1384,10 +1384,12 @@ int denali_init(struct denali_nand_info *denali)
        ret = mtd_device_register(mtd, NULL, 0);
        if (ret) {
                dev_err(denali->dev, "Failed to register MTD: %d\n", ret);
-               goto free_buf;
+               goto cleanup_nand;
        }
        return 0;
 
+cleanup_nand:
+       nand_cleanup(chip);
 free_buf:
        kfree(denali->buf);
 disable_irq: