]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Staging:rtl8192e Fix Comparison to true is error prone
authorJanani Sankara Babu <jananis37@gmail.com>
Mon, 18 Jun 2018 16:05:29 +0000 (12:05 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Jun 2018 03:47:29 +0000 (11:47 +0800)
This patch removes the comaprison to bool value in the code

Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl819x_BAProc.c

index f19470552ffdf9ab6a4b39569c5825f64afe71f7..95ca5f49890ac3a6f0db83e18e9867951403d321 100644 (file)
@@ -365,7 +365,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
        pAdmittedBA = &pTS->TxAdmittedBARecord;
 
 
-       if (pAdmittedBA->bValid == true) {
+       if (pAdmittedBA->bValid) {
                netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n",
                           __func__);
                return -1;
@@ -485,7 +485,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS,
 {
        struct ba_record *pBA = &pTS->TxPendingBARecord;
 
-       if (pBA->bValid == true && bOverwritePending == false)
+       if (pBA->bValid && !bOverwritePending)
                return;
 
        DeActivateBAEntry(ieee, pBA);