]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: isci: remote_device: Mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 28 Nov 2018 04:30:01 +0000 (22:30 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 21 Dec 2018 01:03:56 +0000 (20:03 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

Notice that, in this particular case, a dash is added as a token in order
to separate the "fall through" annotations from the rest of the comment on
the same line, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/isci/remote_device.c

index cc51f38b116d580b9c0c24042714f178de2247ed..9d29edb9f590ed145db6f2f533b9d7cf0d01b129 100644 (file)
@@ -310,7 +310,7 @@ static void isci_remote_device_not_ready(struct isci_host *ihost,
                /* Kill all outstanding requests for the device. */
                sci_remote_device_terminate_requests(idev);
 
-               /* Fall through into the default case... */
+               /* Fall through into the default case... */
        default:
                clear_bit(IDEV_IO_READY, &idev->flags);
                break;
@@ -593,7 +593,7 @@ enum sci_status sci_remote_device_event_handler(struct isci_remote_device *idev,
 
                        break;
                }
-       /* Else, fall through and treat as unhandled... */
+               /* fall through - and treat as unhandled... */
        default:
                dev_dbg(scirdev_to_dev(idev),
                        "%s: device: %p event code: %x: %s\n",