]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
platform/x86: have ACPI_CMPC use depends instead of select for INPUT
authorRandy Dunlap <rdunlap@infradead.org>
Mon, 15 Jan 2018 05:11:18 +0000 (21:11 -0800)
committerDarren Hart (VMware) <dvhart@infradead.org>
Mon, 15 Jan 2018 20:52:07 +0000 (12:52 -0800)
Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

This also makes all platform/x86/ drivers consistent w.r.t depending on
INPUT instead of selecting it.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/Kconfig

index 8a07df54a67e8c9340bdd4874f004745e2535144..de51952f0a927939b4c09b3d49000d304b987f6b 100644 (file)
@@ -838,9 +838,8 @@ config TOSHIBA_WMI
 
 config ACPI_CMPC
        tristate "CMPC Laptop Extras"
-       depends on ACPI
+       depends on ACPI && INPUT
        depends on RFKILL || RFKILL=n
-       select INPUT
        select BACKLIGHT_CLASS_DEVICE
        help
          Support for Intel Classmate PC ACPI devices, including some