]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: hisi_sas: use dma_zalloc_coherent()
authorXiang Chen <chenxiang66@hisilicon.com>
Fri, 23 Mar 2018 16:05:11 +0000 (00:05 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 18 Apr 2018 23:32:51 +0000 (19:32 -0400)
This is a warning coming from Coccinelle, and need to use new interface
dma_zalloc_coherent() instead of dma_alloc_coherent()/memset().

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_main.c

index a216795741428d00535144bb6ecdac01dc7fa7e1..9563dfa72181e632345d81a06f014fec51ced99e 100644 (file)
@@ -1822,13 +1822,11 @@ int hisi_sas_alloc(struct hisi_hba *hisi_hba, struct Scsi_Host *shost)
                goto err_out;
 
        s = HISI_SAS_MAX_ITCT_ENTRIES * sizeof(struct hisi_sas_itct);
-       hisi_hba->itct = dma_alloc_coherent(dev, s, &hisi_hba->itct_dma,
+       hisi_hba->itct = dma_zalloc_coherent(dev, s, &hisi_hba->itct_dma,
                                            GFP_KERNEL);
        if (!hisi_hba->itct)
                goto err_out;
 
-       memset(hisi_hba->itct, 0, s);
-
        hisi_hba->slot_info = devm_kcalloc(dev, max_command_entries,
                                           sizeof(struct hisi_sas_slot),
                                           GFP_KERNEL);