]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] rtl2830: cancel_delayed_work_sync before device removal / kfree
authorErnst Martin Witte <emw-linux-kernel@nocabal.de>
Sat, 9 Jan 2016 20:18:47 +0000 (18:18 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 1 Feb 2016 11:42:03 +0000 (09:42 -0200)
rtl2830_remove  was  calling  kfree(dev) with  possibly  still  active
schedule_delayed_work(&dev->stat_work).   A  similar   bug  in  si2157
caused kernel panics in call_timer_fn e.g. after rmmod cx23885.

Signed-off-by: Ernst Martin Witte <emw-linux-kernel@nocabal.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/rtl2830.c

index b792f305cf15f05fc1289a4bdd0566269bfd15e0..74b771218033d76dee58d151dca1addd54404b13 100644 (file)
@@ -900,6 +900,9 @@ static int rtl2830_remove(struct i2c_client *client)
 
        dev_dbg(&client->dev, "\n");
 
+       /* stop statistics polling */
+       cancel_delayed_work_sync(&dev->stat_work);
+
        i2c_del_mux_adapter(dev->adapter);
        regmap_exit(dev->regmap);
        kfree(dev);