]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/komeda: Use devm_platform_ioremap_resource() in komeda_dev_create()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 21 Sep 2019 17:43:51 +0000 (19:43 +0200)
committerMihail Atanassov <mihail.atanassov@arm.com>
Wed, 6 Nov 2019 17:14:02 +0000 (17:14 +0000)
Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/64a6ea39-3e4b-2ebe-74f7-98720e581e3e@web.de
drivers/gpu/drm/arm/display/komeda/komeda_dev.c

index 937a6d4c486571d06ca61a343d656f857caf5ed6..14d5c5da9e3b2d28bbd35ddc5c66031ed53409f5 100644 (file)
@@ -184,19 +184,12 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
        struct platform_device *pdev = to_platform_device(dev);
        const struct komeda_product_data *product;
        struct komeda_dev *mdev;
-       struct resource *io_res;
        int err = 0;
 
        product = of_device_get_match_data(dev);
        if (!product)
                return ERR_PTR(-ENODEV);
 
-       io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!io_res) {
-               DRM_ERROR("No registers defined.\n");
-               return ERR_PTR(-ENODEV);
-       }
-
        mdev = devm_kzalloc(dev, sizeof(*mdev), GFP_KERNEL);
        if (!mdev)
                return ERR_PTR(-ENOMEM);
@@ -204,7 +197,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
        mutex_init(&mdev->lock);
 
        mdev->dev = dev;
-       mdev->reg_base = devm_ioremap_resource(dev, io_res);
+       mdev->reg_base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(mdev->reg_base)) {
                DRM_ERROR("Map register space failed.\n");
                err = PTR_ERR(mdev->reg_base);