]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 26 Aug 2019 13:05:31 +0000 (15:05 +0200)
committerTony Lindgren <tony@atomide.com>
Mon, 26 Aug 2019 15:59:48 +0000 (08:59 -0700)
A null pointer would be passed to a call of the function "kfree" directly
after a call of the function "kzalloc" failed at one place.
Remove this superfluous function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/hsmmc.c

index 14b9c13c1fa0cb022a9a97874a661ef213aa648a..63423ea6a2408f6d1889a426e8bb1553b2b3075c 100644 (file)
@@ -32,10 +32,8 @@ static int __init omap_hsmmc_pdata_init(struct omap2_hsmmc_info *c,
        char *hc_name;
 
        hc_name = kzalloc(HSMMC_NAME_LEN + 1, GFP_KERNEL);
-       if (!hc_name) {
-               kfree(hc_name);
+       if (!hc_name)
                return -ENOMEM;
-       }
 
        snprintf(hc_name, (HSMMC_NAME_LEN + 1), "mmc%islot%i", c->mmc, 1);
        mmc->name = hc_name;