]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dfs_cache: fix a wrong use of kfree in flush_cache_ent()
authorGen Zhang <blackgod016574@gmail.com>
Tue, 28 May 2019 01:12:39 +0000 (09:12 +0800)
committerSteve French <stfrench@microsoft.com>
Wed, 29 May 2019 00:13:58 +0000 (19:13 -0500)
In flush_cache_ent(), 'ce->ce_path' is allocated by kstrdup_const().
It should be freed by kfree_const(), rather than kfree().

Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/dfs_cache.c

index 85dc89d3a203946bde03da54b3a204c931cd88c4..e3e1c13df4391ea5b45782b0cfb691d34da3d2ee 100644 (file)
@@ -132,7 +132,7 @@ static inline void flush_cache_ent(struct dfs_cache_entry *ce)
                return;
 
        hlist_del_init_rcu(&ce->ce_hlist);
-       kfree(ce->ce_path);
+       kfree_const(ce->ce_path);
        free_tgts(ce);
        dfs_cache_count--;
        call_rcu(&ce->ce_rcu, free_cache_entry);
@@ -422,7 +422,7 @@ alloc_cache_entry(const char *path, const struct dfs_info3_param *refs,
 
        rc = copy_ref_data(refs, numrefs, ce, NULL);
        if (rc) {
-               kfree(ce->ce_path);
+               kfree_const(ce->ce_path);
                kmem_cache_free(dfs_cache_slab, ce);
                ce = ERR_PTR(rc);
        }