]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: iio: adt7316: use correct variable in DAC_internal_Vref read
authorJeremy Fertic <jeremyfertic@gmail.com>
Wed, 12 Dec 2018 00:54:59 +0000 (17:54 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 16 Dec 2018 14:05:55 +0000 (14:05 +0000)
The dac internal vref settings are part of the ldac config register rather
than the dac config register. Change the variable being used so the read
returns the correct result.

Whilst a fix, it is for a driver in heavy churn so do not backport
to stable without taking considerable care and testing.

Signed-off-by: Jeremy Fertic <jeremyfertic@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/addac/adt7316.c

index e5e1f9d6357f0936ecf0864128870548efb7060e..c1050dc678cf807b1c0e16795bb4a860c5114e9c 100644 (file)
@@ -1061,10 +1061,10 @@ static ssize_t adt7316_show_DAC_internal_Vref(struct device *dev,
 
        if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
                return sprintf(buf, "0x%x\n",
-                       (chip->dac_config & ADT7516_DAC_IN_VREF_MASK) >>
+                       (chip->ldac_config & ADT7516_DAC_IN_VREF_MASK) >>
                        ADT7516_DAC_IN_VREF_OFFSET);
        return sprintf(buf, "%d\n",
-                      !!(chip->dac_config & ADT7316_DAC_IN_VREF));
+                      !!(chip->ldac_config & ADT7316_DAC_IN_VREF));
 }
 
 static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,