]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pxa168_eth: convert skb->end into skb_end_pointer(skb)
authorIsaku Yamahata <yamahata@valinux.co.jp>
Fri, 14 Jun 2013 08:58:34 +0000 (17:58 +0900)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Jun 2013 00:12:21 +0000 (17:12 -0700)
The change set of 4305b541, "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
converted skb->end from pointer type to sk_buff_data_t.
The pointed value should be accessed via skb_end_pointer().

Since arm arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
skb->end is effectively pointer. So it doesn't cause a real problem.
But this patch is good for consistency.

Found by inspection. Compile tested only.

Cc: Simon Horman <horms@verge.net.au>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Reviewed-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/pxa168_eth.c

index 2602cf7ba64214d5cd64760dc7df9e4012fc9c83..ec20508f0d6b093197ec62707afcadb27347f590 100644 (file)
@@ -357,7 +357,7 @@ static void rxq_refill(struct net_device *dev)
                /* Get 'used' Rx descriptor */
                used_rx_desc = pep->rx_used_desc_q;
                p_used_rx_desc = &pep->p_rx_desc_area[used_rx_desc];
-               size = skb->end - skb->data;
+               size = skb_end_pointer(skb) - skb->data;
                p_used_rx_desc->buf_ptr = dma_map_single(NULL,
                                                         skb->data,
                                                         size,