]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: omap3isp: fix uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Wed, 23 Aug 2017 13:30:19 +0000 (09:30 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 27 Aug 2017 00:14:42 +0000 (20:14 -0400)
A debug printk statement was copied incorrectly into the new
csi1 parser code and causes a warning there:

drivers/media/platform/omap3isp/isp.c: In function 'isp_probe':
include/linux/dynamic_debug.h:134:3: error: 'i' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Since there is only one lane, the index is never set. This
changes the debug print to always print a zero instead,
keeping the original format of the message.

Fixes: 9211434bad30 ("media: omap3isp: Parse CSI1 configuration from the device tree")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/omap3isp/isp.c

index 83aea08b832dba6872789150a9abdf1b1d00f4a3..1a428fe9f07077e9c8c02fea1cfce723b247cb85 100644 (file)
@@ -2092,7 +2092,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode,
                        buscfg->bus.ccp2.lanecfg.data[0].pol =
                                vep.bus.mipi_csi1.lane_polarity[1];
 
-                       dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i,
+                       dev_dbg(dev, "data lane polarity %u, pos %u\n",
                                buscfg->bus.ccp2.lanecfg.data[0].pol,
                                buscfg->bus.ccp2.lanecfg.data[0].pos);