]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net/smc: parameter cleanup in smc_cdc_get_free_slot()
authorUrsula Braun <ubraun@linux.vnet.ibm.com>
Thu, 21 Sep 2017 07:17:34 +0000 (09:17 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Sep 2017 22:33:03 +0000 (15:33 -0700)
Use the smc_connection as first parameter with smc_cdc_get_free_slot().
This is just a small code cleanup, no functional change.

Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/smc_cdc.c
net/smc/smc_cdc.h
net/smc/smc_tx.c

index a7294edbc22177d2c5b5a21deffaacea1e0855e2..5ef97e5a5f785e32fbe644f2c4b63975c6c56ed2 100644 (file)
@@ -62,10 +62,12 @@ static void smc_cdc_tx_handler(struct smc_wr_tx_pend_priv *pnd_snd,
        bh_unlock_sock(&smc->sk);
 }
 
-int smc_cdc_get_free_slot(struct smc_link *link,
+int smc_cdc_get_free_slot(struct smc_connection *conn,
                          struct smc_wr_buf **wr_buf,
                          struct smc_cdc_tx_pend **pend)
 {
+       struct smc_link *link = &conn->lgr->lnk[SMC_SINGLE_LINK];
+
        return smc_wr_tx_get_free_slot(link, smc_cdc_tx_handler, wr_buf,
                                       (struct smc_wr_tx_pend_priv **)pend);
 }
@@ -118,8 +120,7 @@ int smc_cdc_get_slot_and_msg_send(struct smc_connection *conn)
        struct smc_wr_buf *wr_buf;
        int rc;
 
-       rc = smc_cdc_get_free_slot(&conn->lgr->lnk[SMC_SINGLE_LINK], &wr_buf,
-                                  &pend);
+       rc = smc_cdc_get_free_slot(conn, &wr_buf, &pend);
        if (rc)
                return rc;
 
index 8e1d76f2600796f7384e39c67ebaed94a984ca28..56f883d1159c483daf91ed9b789bdfd1132b4e84 100644 (file)
@@ -206,7 +206,8 @@ static inline void smc_cdc_msg_to_host(struct smc_host_cdc_msg *local,
 
 struct smc_cdc_tx_pend;
 
-int smc_cdc_get_free_slot(struct smc_link *link, struct smc_wr_buf **wr_buf,
+int smc_cdc_get_free_slot(struct smc_connection *conn,
+                         struct smc_wr_buf **wr_buf,
                          struct smc_cdc_tx_pend **pend);
 void smc_cdc_tx_dismiss_slots(struct smc_connection *conn);
 int smc_cdc_msg_send(struct smc_connection *conn, struct smc_wr_buf *wr_buf,
index 3c656beb8820cb16a28f379ee32f2f39a8ce6631..e2228f6d1c25f5e4bfa8db15127c79925e78d787 100644 (file)
@@ -394,8 +394,7 @@ int smc_tx_sndbuf_nonempty(struct smc_connection *conn)
        int rc;
 
        spin_lock_bh(&conn->send_lock);
-       rc = smc_cdc_get_free_slot(&conn->lgr->lnk[SMC_SINGLE_LINK], &wr_buf,
-                                  &pend);
+       rc = smc_cdc_get_free_slot(conn, &wr_buf, &pend);
        if (rc < 0) {
                if (rc == -EBUSY) {
                        struct smc_sock *smc =
@@ -463,8 +462,7 @@ void smc_tx_consumer_update(struct smc_connection *conn)
            ((to_confirm > conn->rmbe_update_limit) &&
             ((to_confirm > (conn->rmbe_size / 2)) ||
              conn->local_rx_ctrl.prod_flags.write_blocked))) {
-               rc = smc_cdc_get_free_slot(&conn->lgr->lnk[SMC_SINGLE_LINK],
-                                          &wr_buf, &pend);
+               rc = smc_cdc_get_free_slot(conn, &wr_buf, &pend);
                if (!rc)
                        rc = smc_cdc_msg_send(conn, wr_buf, pend);
                if (rc < 0) {