]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: qla2xxx: Fix dropped srb resource.
authorQuinn Tran <quinn.tran@cavium.com>
Tue, 11 Sep 2018 17:18:16 +0000 (10:18 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 12 Sep 2018 00:28:09 +0000 (20:28 -0400)
When FW rejects a command due to "entry_status" error (malform IOCB), the srb
resource needs to be returned back for cleanup.  The filter to catch this is
in the wrong location.

Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_isr.c

index 0087174d37667208382a7c66325e510376a03436..d73b04e405902b02d0ea5822b44c105760166e72 100644 (file)
@@ -2845,6 +2845,7 @@ qla2x00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, sts_entry_t *pkt)
        case ELS_IOCB_TYPE:
        case ABORT_IOCB_TYPE:
        case MBX_IOCB_TYPE:
+       default:
                sp = qla2x00_get_sp_from_handle(vha, func, req, pkt);
                if (sp) {
                        sp->done(sp, res);
@@ -2855,7 +2856,6 @@ qla2x00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, sts_entry_t *pkt)
        case ABTS_RESP_24XX:
        case CTIO_TYPE7:
        case CTIO_CRC2:
-       default:
                return 1;
        }
 fatal: