]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mlx4_ib: zero out struct ib_pd when allocating
authorSteve Wise <swise@opengridcomputing.com>
Thu, 1 Mar 2018 21:58:20 +0000 (13:58 -0800)
committerDoug Ledford <dledford@redhat.com>
Thu, 8 Mar 2018 20:03:03 +0000 (15:03 -0500)
Zero out the fields of the struct ib_pd for user mode pds so that
users querying pds via nldev will not get garbage.  For simplicity,
use kzalloc() to allocate the mlx4_ib_pd struct.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mlx4/main.c

index 8d2ee9322f2e04448cfbdbf72112432f8554c963..2e3789fffcab7de4dcfe5cbcffa40a034a273c30 100644 (file)
@@ -1327,7 +1327,7 @@ static struct ib_pd *mlx4_ib_alloc_pd(struct ib_device *ibdev,
        struct mlx4_ib_pd *pd;
        int err;
 
-       pd = kmalloc(sizeof *pd, GFP_KERNEL);
+       pd = kzalloc(sizeof(*pd), GFP_KERNEL);
        if (!pd)
                return ERR_PTR(-ENOMEM);
 
@@ -1343,7 +1343,6 @@ static struct ib_pd *mlx4_ib_alloc_pd(struct ib_device *ibdev,
                        kfree(pd);
                        return ERR_PTR(-EFAULT);
                }
-
        return &pd->ibpd;
 }