s390/cpum_sf: Replace function name in debug statements

Replace hard coded function names in debug statements
by the "%s ...", __func__ construct suggested by checkpatch.pl
script.  Use consistent debug print format of the form variable
blank value. Also add leading 0x for all hex values.
Print allocated page addresses consistantly as hex numbers
with leading 0x.

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

diff --git a/arch/s390/include/asm/cpu_mf.h b/arch/s390/include/asm/cpu_mf.h
index 819803a97c2b2a9032352879fe4ec34880ea4f6b..0d90cbeb89b43e6c4130f50812559ea7a302585d 100644 (file)
--- a/arch/s390/include/asm/cpu_mf.h
+++ b/arch/s390/include/asm/cpu_mf.h
@@ -313,7 +313,7 @@ static inline unsigned long *trailer_entry_ptr(unsigned long v)
        return (unsigned long *) ret;
 }
 
-/* Return if the entry in the sample data block table (sdbt)
+/* Return true if the entry in the sample data block table (sdbt)
  * is a link to the next sdbt */
 static inline int is_link_entry(unsigned long *s)
 {

diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c
index 69506fdbd9a1ef3667c36221407989518b680e47..4414094550a4a08f938b0f3df92ae13e68198836 100644 (file)
--- a/arch/s390/kernel/perf_cpum_sf.c
+++ b/arch/s390/kernel/perf_cpum_sf.c
@@ -156,8 +156,8 @@ static void free_sampling_buffer(struct sf_buffer *sfb)
                }
        }
 
-       debug_sprintf_event(sfdbg, 5, "%s freed sdbt %p\n", __func__,
-                           sfb->sdbt);
+       debug_sprintf_event(sfdbg, 5, "%s: freed sdbt %#lx\n", __func__,
+                           (unsigned long)sfb->sdbt);
        memset(sfb, 0, sizeof(*sfb));
 }
 
@@ -213,9 +213,10 @@ static int realloc_sampling_buffer(struct sf_buffer *sfb,
         */
        if (sfb->sdbt != get_next_sdbt(tail)) {
                debug_sprintf_event(sfdbg, 3, "%s: "
-                                   "sampling buffer is not linked: origin %p"
-                                   " tail %p\n", __func__,
-                                   (void *)sfb->sdbt, (void *)tail);
+                                   "sampling buffer is not linked: origin %#lx"
+                                   " tail %#lx\n", __func__,
+                                   (unsigned long)sfb->sdbt,
+                                   (unsigned long)tail);
                return -EINVAL;
        }
 
@@ -251,8 +252,8 @@ static int realloc_sampling_buffer(struct sf_buffer *sfb,
        *tail = (unsigned long) sfb->sdbt + 1;
        sfb->tail = tail;
 
-       debug_sprintf_event(sfdbg, 4, "realloc_sampling_buffer: new buffer"
-                           " settings: sdbt %lu sdb %lu\n",
+       debug_sprintf_event(sfdbg, 4, "%s: new buffer"
+                           " settings: sdbt %lu sdb %lu\n", __func__,
                            sfb->num_sdbt, sfb->num_sdb);
        return rc;
 }
@@ -292,12 +293,13 @@ static int alloc_sampling_buffer(struct sf_buffer *sfb, unsigned long num_sdb)
        rc = realloc_sampling_buffer(sfb, num_sdb, GFP_KERNEL);
        if (rc) {
                free_sampling_buffer(sfb);
-               debug_sprintf_event(sfdbg, 4, "alloc_sampling_buffer: "
-                       "realloc_sampling_buffer failed with rc %i\n", rc);
+               debug_sprintf_event(sfdbg, 4, "%s: "
+                       "realloc_sampling_buffer failed with rc %i\n",
+                       __func__, rc);
        } else
                debug_sprintf_event(sfdbg, 4,
-                       "alloc_sampling_buffer: tear %p dear %p\n",
-                       sfb->sdbt, (void *)*sfb->sdbt);
+                       "%s: tear %#lx dear %#lx\n", __func__,
+                       (unsigned long)sfb->sdbt, (unsigned long)*sfb->sdbt);
        return rc;
 }
 
@@ -465,8 +467,8 @@ static void sfb_account_overflows(struct cpu_hw_sf *cpuhw,
        if (num)
                sfb_account_allocs(num, hwc);
 
-       debug_sprintf_event(sfdbg, 5, "sfb: overflow: overflow %llu ratio %lu"
-                           " num %lu\n", OVERFLOW_REG(hwc), ratio, num);
+       debug_sprintf_event(sfdbg, 5, "%s: overflow %llu ratio %lu num %lu\n",
+                           __func__, OVERFLOW_REG(hwc), ratio, num);
        OVERFLOW_REG(hwc) = 0;
 }
 
@@ -504,13 +506,13 @@ static void extend_sampling_buffer(struct sf_buffer *sfb,
         */
        rc = realloc_sampling_buffer(sfb, num, GFP_ATOMIC);
        if (rc)
-               debug_sprintf_event(sfdbg, 5, "sfb: extend: realloc "
-                                   "failed with rc %i\n", rc);
+               debug_sprintf_event(sfdbg, 5, "%s: realloc failed with rc %i\n",
+                                   __func__, rc);
 
        if (sfb_has_pending_allocs(sfb, hwc))
-               debug_sprintf_event(sfdbg, 5, "sfb: extend: "
+               debug_sprintf_event(sfdbg, 5, "%s: "
                                    "req %lu alloc %lu remaining %lu\n",
-                                   num, sfb->num_sdb - num_old,
+                                   __func__, num, sfb->num_sdb - num_old,
                                    sfb_pending_allocs(sfb, hwc));
 }
 
@@ -698,9 +700,9 @@ static unsigned long getrate(bool freq, unsigned long sample,
                 */
                if (sample_rate_to_freq(si, rate) >
                    sysctl_perf_event_sample_rate) {
-                       debug_sprintf_event(sfdbg, 1,
+                       debug_sprintf_event(sfdbg, 1, "%s: "
                                            "Sampling rate exceeds maximum "
-                                           "perf sample rate\n");
+                                           "perf sample rate\n", __func__);
                        rate = 0;
                }
        }
@@ -745,10 +747,9 @@ static int __hw_perf_event_init_rate(struct perf_event *event,
        attr->sample_period = rate;
        SAMPL_RATE(hwc) = rate;
        hw_init_period(hwc, SAMPL_RATE(hwc));
-       debug_sprintf_event(sfdbg, 4, "__hw_perf_event_init_rate:"
-                           "cpu:%d period:%#llx freq:%d,%#lx\n", event->cpu,
-                           event->attr.sample_period, event->attr.freq,
-                           SAMPLE_FREQ_MODE(hwc));
+       debug_sprintf_event(sfdbg, 4, "%s: cpu %d period %#llx freq %d,%#lx\n",
+                           __func__, event->cpu, event->attr.sample_period,
+                           event->attr.freq, SAMPLE_FREQ_MODE(hwc));
        return 0;
 }
 
@@ -973,12 +974,11 @@ static void cpumsf_pmu_enable(struct pmu *pmu)
        /* Load current program parameter */
        lpp(&S390_lowcore.lpp);
 
-       debug_sprintf_event(sfdbg, 6, "pmu_enable: es %i cs %i ed %i cd %i "
-                           "interval %#lx tear %p dear %p\n",
+       debug_sprintf_event(sfdbg, 6, "%s: es %i cs %i ed %i cd %i "
+                           "interval %#lx tear %#lx dear %#lx\n", __func__,
                            cpuhw->lsctl.es, cpuhw->lsctl.cs, cpuhw->lsctl.ed,
                            cpuhw->lsctl.cd, cpuhw->lsctl.interval,
-                           (void *) cpuhw->lsctl.tear,
-                           (void *) cpuhw->lsctl.dear);
+                           cpuhw->lsctl.tear, cpuhw->lsctl.dear);
 }
 
 static void cpumsf_pmu_disable(struct pmu *pmu)
@@ -1019,8 +1019,8 @@ static void cpumsf_pmu_disable(struct pmu *pmu)
                        cpuhw->lsctl.dear = si.dear;
                }
        } else
-               debug_sprintf_event(sfdbg, 3, "cpumsf_pmu_disable: "
-                                   "qsi() failed with err %i\n", err);
+               debug_sprintf_event(sfdbg, 3, "%s: qsi() failed with err %i\n",
+                                   __func__, err);
 
        cpuhw->flags &= ~PMU_F_ENABLED;
 }
@@ -1265,9 +1265,9 @@ static void hw_perf_event_update(struct perf_event *event, int flush_all)
                        sampl_overflow += te->overflow;
 
                /* Timestamps are valid for full sample-data-blocks only */
-               debug_sprintf_event(sfdbg, 6, "%s: sdbt %p "
+               debug_sprintf_event(sfdbg, 6, "%s: sdbt %#lx "
                                    "overflow %llu timestamp %#llx\n",
-                                   __func__, sdbt, te->overflow,
+                                   __func__, (unsigned long)sdbt, te->overflow,
                                    (te->f) ? trailer_timestamp(te) : 0ULL);
 
                /* Collect all samples from a single sample-data-block and
@@ -1312,8 +1312,10 @@ static void hw_perf_event_update(struct perf_event *event, int flush_all)
                                                 sampl_overflow, 1 + num_sdb);
        if (sampl_overflow || event_overflow)
                debug_sprintf_event(sfdbg, 4, "%s: "
-                                   "overflow stats: sample %llu event %llu\n",
-                                   __func__, sampl_overflow, event_overflow);
+                                   "overflows: sample %llu event %llu"
+                                   " total %llu num_sdb %llu\n",
+                                   __func__, sampl_overflow, event_overflow,
+                                   OVERFLOW_REG(hwc), num_sdb);
 }
 
 #define AUX_SDB_INDEX(aux, i) ((i) % aux->sfb.num_sdb)
@@ -1424,10 +1426,10 @@ static int aux_output_begin(struct perf_output_handle *handle,
        cpuhw->lsctl.tear = base + offset * sizeof(unsigned long);
        cpuhw->lsctl.dear = aux->sdb_index[head];
 
-       debug_sprintf_event(sfdbg, 6, "aux_output_begin: "
+       debug_sprintf_event(sfdbg, 6, "%s: "
                            "head->alert_mark->empty_mark (num_alert, range)"
                            "[%#lx -> %#lx -> %#lx] (%#lx, %#lx) "
-                           "tear index %#lx, tear %#lx dear %#lx\n",
+                           "tear index %#lx, tear %#lx dear %#lx\n", __func__,
                            aux->head, aux->alert_mark, aux->empty_mark,
                            AUX_SDB_NUM_ALERT(aux), range,
                            head / CPUM_SF_SDB_PER_TABLE,
@@ -1571,7 +1573,9 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw)
                        pr_err("The AUX buffer with %lu pages for the "
                               "diagnostic-sampling mode is full\n",
                                num_sdb);
-                       debug_sprintf_event(sfdbg, 1, "AUX buffer used up\n");
+                       debug_sprintf_event(sfdbg, 1,
+                                           "%s: AUX buffer used up\n",
+                                           __func__);
                        break;
                }
                if (WARN_ON_ONCE(!aux))
@@ -1594,23 +1598,25 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw)
                        perf_aux_output_end(&cpuhw->handle, size);
                        pr_err("Sample data caused the AUX buffer with %lu "
                               "pages to overflow\n", num_sdb);
-                       debug_sprintf_event(sfdbg, 1, "head %#lx range %#lx "
-                                           "overflow %#llx\n",
+                       debug_sprintf_event(sfdbg, 1, "%s: head %#lx range %#lx "
+                                           "overflow %#llx\n", __func__,
                                            aux->head, range, overflow);
                } else {
                        size = AUX_SDB_NUM_ALERT(aux) << PAGE_SHIFT;
                        perf_aux_output_end(&cpuhw->handle, size);
-                       debug_sprintf_event(sfdbg, 6, "head %#lx alert %#lx "
+                       debug_sprintf_event(sfdbg, 6, "%s: head %#lx alert %#lx "
                                            "already full, try another\n",
+                                           __func__,
                                            aux->head, aux->alert_mark);
                }
        }
 
        if (done)
-               debug_sprintf_event(sfdbg, 6, "aux_reset_buffer: "
+               debug_sprintf_event(sfdbg, 6, "%s: aux_reset_buffer "
                                    "[%#lx -> %#lx -> %#lx] (%#lx, %#lx)\n",
-                                   aux->head, aux->alert_mark, aux->empty_mark,
-                                   AUX_SDB_NUM_ALERT(aux), range);
+                                   __func__, aux->head, aux->alert_mark,
+                                   aux->empty_mark, AUX_SDB_NUM_ALERT(aux),
+                                   range);
 }
 
 /*
@@ -1633,8 +1639,8 @@ static void aux_buffer_free(void *data)
        kfree(aux->sdb_index);
        kfree(aux);
 
-       debug_sprintf_event(sfdbg, 4, "aux_buffer_free: free "
-                           "%lu SDBTs\n", num_sdbt);
+       debug_sprintf_event(sfdbg, 4, "%s: free "
+                           "%lu SDBTs\n", __func__, num_sdbt);
 }
 
 static void aux_sdb_init(unsigned long sdb)
@@ -1742,9 +1748,8 @@ static void *aux_buffer_setup(struct perf_event *event, void **pages,
         */
        aux->empty_mark = sfb->num_sdb - 1;
 
-       debug_sprintf_event(sfdbg, 4, "aux_buffer_setup: setup %lu SDBTs"
-                           " and %lu SDBs\n",
-                           sfb->num_sdbt, sfb->num_sdb);
+       debug_sprintf_event(sfdbg, 4, "%s: setup %lu SDBTs and %lu SDBs\n",
+                           __func__, sfb->num_sdbt, sfb->num_sdb);
 
        return aux;
 
@@ -1797,9 +1802,9 @@ static int cpumsf_pmu_check_period(struct perf_event *event, u64 value)
        event->attr.sample_period = rate;
        SAMPL_RATE(&event->hw) = rate;
        hw_init_period(&event->hw, SAMPL_RATE(&event->hw));
-       debug_sprintf_event(sfdbg, 4, "cpumsf_pmu_check_period:"
-                           "cpu:%d value:%#llx period:%#llx freq:%d\n",
-                           event->cpu, value,
+       debug_sprintf_event(sfdbg, 4, "%s:"
+                           " cpu %d value %#llx period %#llx freq %d\n",
+                           __func__, event->cpu, value,
                            event->attr.sample_period, do_freq);
        return 0;
 }
@@ -2030,7 +2035,7 @@ static void cpumf_measurement_alert(struct ext_code ext_code,
 
        /* Report measurement alerts only for non-PRA codes */
        if (alert != CPU_MF_INT_SF_PRA)
-               debug_sprintf_event(sfdbg, 6, "measurement alert: %#x\n",
+               debug_sprintf_event(sfdbg, 6, "%s: alert %#x\n", __func__,
                                    alert);
 
        /* Sampling authorization change request */