]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: fsl-mc: Avoid section mismatch
authorThierry Reding <treding@nvidia.com>
Mon, 15 Feb 2016 13:22:23 +0000 (14:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Feb 2016 04:28:20 +0000 (20:28 -0800)
The fsl_mc_allocator_driver_exit() function is marked __exit, but is
called by the error handling code in fsl_mc_allocator_driver_init().
This results in a section mismatch, which in turn could lead to
executing random code.

Remove the __exit annotation to fix this.

Cc: J. German Rivera <German.Rivera@freescale.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-mc/bus/mc-allocator.c
drivers/staging/fsl-mc/include/mc-private.h

index c5fa628411ec68a320ff17e80bd75953dbf5a8c0..86f8543c2b9a5485d54dcc84b1526b1b873251fa 100644 (file)
@@ -756,7 +756,7 @@ int __init fsl_mc_allocator_driver_init(void)
        return fsl_mc_driver_register(&fsl_mc_allocator_driver);
 }
 
-void __exit fsl_mc_allocator_driver_exit(void)
+void fsl_mc_allocator_driver_exit(void)
 {
        fsl_mc_driver_unregister(&fsl_mc_allocator_driver);
 }
index be72a44ba0641dd342d19da5a49aa5f71080483f..ee5f1d2bf604ed054f716eebc8eef64c17ac5554 100644 (file)
@@ -123,7 +123,7 @@ void dprc_driver_exit(void);
 
 int __init fsl_mc_allocator_driver_init(void);
 
-void __exit fsl_mc_allocator_driver_exit(void);
+void fsl_mc_allocator_driver_exit(void);
 
 int __must_check fsl_mc_resource_allocate(struct fsl_mc_bus *mc_bus,
                                          enum fsl_mc_pool_type pool_type,