]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi: spi-mem: stm32-qspi: avoid memory corruption at low frequency
authorLudovic Barre <ludovic.barre@st.com>
Fri, 8 Mar 2019 13:12:20 +0000 (14:12 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 15 Mar 2019 16:32:33 +0000 (16:32 +0000)
This patch solves a memory corruption seen at 8 MHz.
To avoid such issue, timeout counter is disabled.

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32-qspi.c

index 3b2a9a6b990da1c4db2c4f94da92dec463ca1b8b..7354f9d68dba13ee142f7bb196adb50ab663e4c9 100644 (file)
@@ -76,7 +76,6 @@
 #define QSPI_PSMAR             0x28
 #define QSPI_PIR               0x2c
 #define QSPI_LPTR              0x30
-#define LPTR_DFT_TIMEOUT       0x10
 
 #define STM32_QSPI_MAX_MMAP_SZ SZ_256M
 #define STM32_QSPI_MAX_NORCHIP 2
@@ -372,8 +371,7 @@ static int stm32_qspi_setup(struct spi_device *spi)
        flash->presc = presc;
 
        mutex_lock(&qspi->lock);
-       writel_relaxed(LPTR_DFT_TIMEOUT, qspi->io_base + QSPI_LPTR);
-       cr = FIELD_PREP(CR_FTHRES_MASK, 3) | CR_TCEN | CR_SSHIFT | CR_EN;
+       cr = FIELD_PREP(CR_FTHRES_MASK, 3) | CR_SSHIFT | CR_EN;
        writel_relaxed(cr, qspi->io_base + QSPI_CR);
 
        /* set dcr fsize to max address */