USB: dwc3: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index 2f07be1e1f3196d3a528e782cfaf84a865b8a9d4..df8e73ec3342eca2365d976f5dcfd00c6c8da446 100644 (file)
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -716,9 +716,6 @@ static void dwc3_debugfs_create_endpoint_dir(struct dwc3_ep *dep,
        struct dentry           *dir;
 
        dir = debugfs_create_dir(dep->name, parent);
-       if (IS_ERR_OR_NULL(dir))
-               return;
-
        dwc3_debugfs_create_endpoint_files(dep, dir);
 }
 
@@ -740,49 +737,31 @@ static void dwc3_debugfs_create_endpoint_dirs(struct dwc3 *dwc,
 void dwc3_debugfs_init(struct dwc3 *dwc)
 {
        struct dentry           *root;
-       struct dentry           *file;
-
-       root = debugfs_create_dir(dev_name(dwc->dev), NULL);
-       if (IS_ERR_OR_NULL(root)) {
-               if (!root)
-                       dev_err(dwc->dev, "Can't create debugfs root\n");
-               return;
-       }
-       dwc->root = root;
 
        dwc->regset = kzalloc(sizeof(*dwc->regset), GFP_KERNEL);
-       if (!dwc->regset) {
-               debugfs_remove_recursive(root);
+       if (!dwc->regset)
                return;
-       }
 
        dwc->regset->regs = dwc3_regs;
        dwc->regset->nregs = ARRAY_SIZE(dwc3_regs);
        dwc->regset->base = dwc->regs - DWC3_GLOBALS_REGS_START;
 
-       file = debugfs_create_regset32("regdump", S_IRUGO, root, dwc->regset);
-       if (!file)
-               dev_dbg(dwc->dev, "Can't create debugfs regdump\n");
+       root = debugfs_create_dir(dev_name(dwc->dev), NULL);
+       dwc->root = root;
+
+       debugfs_create_regset32("regdump", S_IRUGO, root, dwc->regset);
 
        if (IS_ENABLED(CONFIG_USB_DWC3_DUAL_ROLE)) {
-               file = debugfs_create_file("mode", S_IRUGO | S_IWUSR, root,
-                               dwc, &dwc3_mode_fops);
-               if (!file)
-                       dev_dbg(dwc->dev, "Can't create debugfs mode\n");
+               debugfs_create_file("mode", S_IRUGO | S_IWUSR, root, dwc,
+                                   &dwc3_mode_fops);
        }
 
        if (IS_ENABLED(CONFIG_USB_DWC3_DUAL_ROLE) ||
                        IS_ENABLED(CONFIG_USB_DWC3_GADGET)) {
-               file = debugfs_create_file("testmode", S_IRUGO | S_IWUSR, root,
-                               dwc, &dwc3_testmode_fops);
-               if (!file)
-                       dev_dbg(dwc->dev, "Can't create debugfs testmode\n");
-
-               file = debugfs_create_file("link_state", S_IRUGO | S_IWUSR,
-                               root, dwc, &dwc3_link_state_fops);
-               if (!file)
-                       dev_dbg(dwc->dev, "Can't create debugfs link_state\n");
-
+               debugfs_create_file("testmode", S_IRUGO | S_IWUSR, root, dwc,
+                                   &dwc3_testmode_fops);
+               debugfs_create_file("link_state", S_IRUGO | S_IWUSR, root, dwc,
+                                   &dwc3_link_state_fops);
                dwc3_debugfs_create_endpoint_dirs(dwc, root);
        }
 }