]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i2c: iproc: Add full name of devicetree node to adapter name
authorLori Hikichi <lori.hikichi@broadcom.com>
Thu, 8 Aug 2019 03:37:53 +0000 (09:07 +0530)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 30 Aug 2019 12:59:20 +0000 (14:59 +0200)
Add the full name of the devicetree node to the adapter name.
Without this change, all adapters have the same name making it difficult
to distinguish between multiple instances.
The most obvious way to see this is to use the utility i2c_detect.
e.g. "i2c-detect -l"

Before
i2c-1 i2c Broadcom iProc I2C adapter I2C adapter
i2c-0 i2c Broadcom iProc I2C adapter I2C adapter

After
i2c-1 i2c Broadcom iProc (i2c@e0000) I2C adapter
i2c-0 i2c Broadcom iProc (i2c@b0000) I2C adapter

Now it is easy to figure out which adapter maps to a which DT node.

Signed-off-by: Lori Hikichi <lori.hikichi@broadcom.com>
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-bcm-iproc.c

index 2c7f145a036e62d291afd5a645430fcb12966c71..ee5578173fb158006674df6626b2f63892f6f641 100644 (file)
@@ -917,7 +917,9 @@ static int bcm_iproc_i2c_probe(struct platform_device *pdev)
 
        adap = &iproc_i2c->adapter;
        i2c_set_adapdata(adap, iproc_i2c);
-       strlcpy(adap->name, "Broadcom iProc I2C adapter", sizeof(adap->name));
+       snprintf(adap->name, sizeof(adap->name),
+               "Broadcom iProc (%s)",
+               of_node_full_name(iproc_i2c->device->of_node));
        adap->algo = &bcm_iproc_algo;
        adap->quirks = &bcm_iproc_i2c_quirks;
        adap->dev.parent = &pdev->dev;