]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: vc04_services: fix setup_timer.cocci warnings
authorkbuild test robot <fengguang.wu@intel.com>
Fri, 11 Nov 2016 08:10:20 +0000 (16:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 Nov 2016 14:38:41 +0000 (15:38 +0100)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1817:2-12: Use setup_timer function for function on line 1818.

 Use setup_timer function instead of initializing timer with the function
 and data fields
Generated by: scripts/coccinelle/api/setup_timer.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index 8fcd9400d968f420f4606aacbf5534dd73ab009b..5418dd6feba4a33ac0383d92ea69d7eb1b782c59 100644 (file)
@@ -1814,9 +1814,8 @@ vchiq_arm_init_state(VCHIQ_STATE_T *state, VCHIQ_ARM_STATE_T *arm_state)
 
                arm_state->suspend_timer_timeout = SUSPEND_TIMER_TIMEOUT_MS;
                arm_state->suspend_timer_running = 0;
-               init_timer(&arm_state->suspend_timer);
-               arm_state->suspend_timer.data = (unsigned long)(state);
-               arm_state->suspend_timer.function = suspend_timer_callback;
+               setup_timer(&arm_state->suspend_timer, suspend_timer_callback,
+                           (unsigned long)(state));
 
                arm_state->first_connect = 0;