caif: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Richard Fontana <rfontana@redhat.com>
Cc: Steve Winslow <swinslow@gmail.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index ed3c437063dc66390ae9d9f5cb61e773a9efe7cd..40b079162804fb0c7d43d000392abb5c60448c37 100644 (file)
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -94,26 +94,20 @@ static inline void update_tty_status(struct ser_device *ser)
 }
 static inline void debugfs_init(struct ser_device *ser, struct tty_struct *tty)
 {
-       ser->debugfs_tty_dir =
-                       debugfs_create_dir(tty->name, debugfsdir);
-       if (!IS_ERR(ser->debugfs_tty_dir)) {
-               debugfs_create_blob("last_tx_msg", 0400,
-                                   ser->debugfs_tty_dir,
-                                   &ser->tx_blob);
+       ser->debugfs_tty_dir = debugfs_create_dir(tty->name, debugfsdir);
 
-               debugfs_create_blob("last_rx_msg", 0400,
-                                   ser->debugfs_tty_dir,
-                                   &ser->rx_blob);
+       debugfs_create_blob("last_tx_msg", 0400, ser->debugfs_tty_dir,
+                           &ser->tx_blob);
 
-               debugfs_create_x32("ser_state", 0400,
-                                  ser->debugfs_tty_dir,
-                                  (u32 *)&ser->state);
+       debugfs_create_blob("last_rx_msg", 0400, ser->debugfs_tty_dir,
+                           &ser->rx_blob);
 
-               debugfs_create_x8("tty_status", 0400,
-                                 ser->debugfs_tty_dir,
-                                 &ser->tty_status);
+       debugfs_create_x32("ser_state", 0400, ser->debugfs_tty_dir,
+                          (u32 *)&ser->state);
+
+       debugfs_create_x8("tty_status", 0400, ser->debugfs_tty_dir,
+                         &ser->tty_status);
 
-       }
        ser->tx_blob.data = ser->tx_data;
        ser->tx_blob.size = 0;
        ser->rx_blob.data = ser->rx_data;

diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c
index 27e93a438dd93b515fe4e74414413d54b4a77a01..eb426822ad066c2ceb363ace7925aa4bb81dd067 100644 (file)
--- a/drivers/net/caif/caif_virtio.c
+++ b/drivers/net/caif/caif_virtio.c
@@ -623,11 +623,7 @@ static void cfv_netdev_setup(struct net_device *netdev)
 /* Create debugfs counters for the device */
 static inline void debugfs_init(struct cfv_info *cfv)
 {
-       cfv->debugfs =
-               debugfs_create_dir(netdev_name(cfv->ndev), NULL);
-
-       if (IS_ERR(cfv->debugfs))
-               return;
+       cfv->debugfs = debugfs_create_dir(netdev_name(cfv->ndev), NULL);
 
        debugfs_create_u32("rx-napi-complete", 0400, cfv->debugfs,
                           &cfv->stats.rx_napi_complete);