]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/ttm: fix dma_fence refcount imbalance on error path
authorLin Yi <teroincn@163.com>
Wed, 10 Apr 2019 02:23:34 +0000 (10:23 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 11 Apr 2019 15:02:21 +0000 (10:02 -0500)
the ttm_bo_add_move_fence takes a reference to the struct dma_fence, but
failed to release it on the error path, leading to a memory leak.
add dma_fence_put before return when error occur.

Signed-off-by: Lin Yi <teroincn@163.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/ttm/ttm_bo.c

index 3f56647cdb35f94ddcead862b286516ad903150e..0fa5034b9f9e05bc0f8511d6f3c6545030699fe6 100644 (file)
@@ -876,8 +876,10 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,
                reservation_object_add_shared_fence(bo->resv, fence);
 
                ret = reservation_object_reserve_shared(bo->resv, 1);
-               if (unlikely(ret))
+               if (unlikely(ret)) {
+                       dma_fence_put(fence);
                        return ret;
+               }
 
                dma_fence_put(bo->moving);
                bo->moving = fence;