]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: ethernet: stmmac: drop unused variable in stm32mp1_set_mode()
authorChristophe Roullier <christophe.roullier@st.com>
Mon, 4 Nov 2019 10:51:00 +0000 (11:51 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Nov 2019 19:31:21 +0000 (11:31 -0800)
Building with W=1 (cf.scripts/Makefile.extrawarn) outputs:
warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

Drop the unused 'ret' variable.

Signed-off-by: Christophe Roullier <christophe.roullier@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c

index 4ef041bdf6a1c6ff1339e3aad0925d3688d3dd3b..595af2ec89fb912c9f395df1e947e89cba0cfd1c 100644 (file)
@@ -175,7 +175,7 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
 {
        struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
        u32 reg = dwmac->mode_reg;
-       int val, ret;
+       int val;
 
        switch (plat_dat->interface) {
        case PHY_INTERFACE_MODE_MII:
@@ -211,8 +211,8 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
        }
 
        /* Need to update PMCCLRR (clear register) */
-       ret = regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
-                          dwmac->ops->syscfg_eth_mask);
+       regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
+                    dwmac->ops->syscfg_eth_mask);
 
        /* Update PMCSETR (set register) */
        return regmap_update_bits(dwmac->regmap, reg,