staging: erofs: return the error value if fill_inline_data() fails

We should consider the error returned by fill_inline_data() when filling
last page in fill_inode(). If not getting inode will be successful even
though last page is bad. That is illogical. Also change -EAGAIN to 0 in
fill_inline_data() to stand for successful filling.

Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index 1d467322bacf80d078f5a1f4019ce1712f8a0071..35fc5987185ef41e2b9dd91f3f34f9f613234d44 100644 (file)
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -155,7 +155,7 @@ static int fill_inline_data(struct inode *inode, void *data,
                inode->i_link = lnk;
                set_inode_fast_symlink(inode);
        }
-       return -EAGAIN;
+       return 0;
 }
 
 static int fill_inode(struct inode *inode, int isdir)
@@ -217,7 +217,7 @@ static int fill_inode(struct inode *inode, int isdir)
                inode->i_mapping->a_ops = &erofs_raw_access_aops;
 
                /* fill last page if inline data is available */
-               fill_inline_data(inode, data, ofs);
+               err = fill_inline_data(inode, data, ofs);
        }
 
 out_unlock: