]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
leds: 88pm860x: Use of_node_name_eq for node name comparisons
authorRob Herring <robh@kernel.org>
Wed, 5 Dec 2018 19:50:27 +0000 (13:50 -0600)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Thu, 6 Dec 2018 20:30:08 +0000 (21:30 +0100)
Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

For instances using of_node_cmp, this has the side effect of now using
case sensitive comparisons. This should not matter for any FDT based
system which this is.

Cc: linux-leds@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-88pm860x.c

index 77a104d2b1243a503d8daa0660d73ae19baa819e..036d4a5366971d3cae2c717360d2247136cb60a1 100644 (file)
@@ -130,7 +130,7 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
                return -ENODEV;
        }
        for_each_child_of_node(nproot, np) {
-               if (!of_node_cmp(np->name, data->name)) {
+               if (of_node_name_eq(np, data->name)) {
                        of_property_read_u32(np, "marvell,88pm860x-iset",
                                             &iset);
                        data->iset = PM8606_LED_CURRENT(iset);