]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Bluetooth: hci_qca: Remove set but not used variable 'opcode'
authorYueHaibing <yuehaibing@huawei.com>
Wed, 8 Jan 2020 01:54:31 +0000 (01:54 +0000)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 8 Jan 2020 20:47:28 +0000 (21:47 +0100)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/bluetooth/hci_qca.c: In function 'qca_controller_memdump':
drivers/bluetooth/hci_qca.c:980:6: warning:
 variable 'opcode' set but not used [-Wunused-but-set-variable]

It is never used since commit d841502c79e3 ("Bluetooth: hci_qca: Collect
controller memory dump during SSR"), so remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_qca.c

index a17260641283aa0b24a00b2ab6ad93d3ace88e1e..82e4cd4b66633cc76efb3793ef1052119aed8ee7 100644 (file)
@@ -977,7 +977,7 @@ static void qca_controller_memdump(struct work_struct *work)
        struct qca_dump_size *dump;
        char *memdump_buf;
        char nullBuff[QCA_DUMP_PACKET_SIZE] = { 0 };
-       u16 opcode, seq_no;
+       u16 seq_no;
        u32 dump_size;
 
        while ((skb = skb_dequeue(&qca->rx_memdump_q))) {
@@ -993,7 +993,6 @@ static void qca_controller_memdump(struct work_struct *work)
 
                qca->memdump_state = QCA_MEMDUMP_COLLECTING;
                cmd_hdr = (void *) skb->data;
-               opcode = __le16_to_cpu(cmd_hdr->opcode);
                seq_no = __le16_to_cpu(cmd_hdr->seq_no);
                skb_pull(skb, sizeof(struct qca_memdump_event_hdr));