]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
bnxt_en: query force speeds before disabling autoneg mode.
authorVasundhara Volam <vasundhara-v.volam@broadcom.com>
Sun, 16 Dec 2018 23:46:31 +0000 (18:46 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Dec 2018 07:08:53 +0000 (23:08 -0800)
With autoneg enabled, PHY loopback test fails. To disable autoneg,
driver needs to send a valid forced speed to FW. FW is not sending
async event for invalid speeds. To fix this, query forced speeds
and send the correct speed when disabling autoneg mode.

Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

index 14e9b73bbfa9668af58fce78b757a52261c2a257..997775777dbebab6a520ca91bcc29b52a1760bc4 100644 (file)
@@ -2585,17 +2585,37 @@ static int bnxt_hwrm_mac_loopback(struct bnxt *bp, bool enable)
        return hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
 }
 
+static int bnxt_query_force_speeds(struct bnxt *bp, u16 *force_speeds)
+{
+       struct hwrm_port_phy_qcaps_output *resp = bp->hwrm_cmd_resp_addr;
+       struct hwrm_port_phy_qcaps_input req = {0};
+       int rc;
+
+       bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_PORT_PHY_QCAPS, -1, -1);
+       mutex_lock(&bp->hwrm_cmd_lock);
+       rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
+       if (!rc)
+               *force_speeds = le16_to_cpu(resp->supported_speeds_force_mode);
+
+       mutex_unlock(&bp->hwrm_cmd_lock);
+       return rc;
+}
+
 static int bnxt_disable_an_for_lpbk(struct bnxt *bp,
                                    struct hwrm_port_phy_cfg_input *req)
 {
        struct bnxt_link_info *link_info = &bp->link_info;
-       u16 fw_advertising = link_info->advertising;
+       u16 fw_advertising;
        u16 fw_speed;
        int rc;
 
        if (!link_info->autoneg)
                return 0;
 
+       rc = bnxt_query_force_speeds(bp, &fw_advertising);
+       if (rc)
+               return rc;
+
        fw_speed = PORT_PHY_CFG_REQ_FORCE_LINK_SPEED_1GB;
        if (netif_carrier_ok(bp->dev))
                fw_speed = bp->link_info.link_speed;