]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ice: Check for actual link state of port after reset
authorDave Ertman <david.m.ertman@intel.com>
Thu, 20 Sep 2018 00:23:15 +0000 (17:23 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 2 Oct 2018 14:15:22 +0000 (07:15 -0700)
We are currently replaying the link state of a port after a reset, but
it is possible that the link state of a port can change during the reset
process. So check for the current link state of a port during the rebuild
process of a reset.

Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_common.c
drivers/net/ethernet/intel/ice/ice_common.h
drivers/net/ethernet/intel/ice/ice_main.c

index 4e0ed2364a6b7c5ea29decb358af24fc50c803f5..9ff29137586900e90b5d86e848b0002fee12e6f5 100644 (file)
@@ -1740,8 +1740,7 @@ ice_aq_set_phy_cfg(struct ice_hw *hw, u8 lport,
  * ice_update_link_info - update status of the HW network link
  * @pi: port info structure of the interested logical port
  */
-static enum ice_status
-ice_update_link_info(struct ice_port_info *pi)
+enum ice_status ice_update_link_info(struct ice_port_info *pi)
 {
        struct ice_aqc_get_phy_caps_data *pcaps;
        struct ice_phy_info *phy_info;
index 5493266d42040a3ecf17624a24c52c0944582b03..7b2a5bb2e5507a0b31d52cf30800aad4f0cede66 100644 (file)
@@ -21,6 +21,7 @@ ice_clean_rq_elem(struct ice_hw *hw, struct ice_ctl_q_info *cq,
                  struct ice_rq_event_info *e, u16 *pending);
 enum ice_status
 ice_get_link_status(struct ice_port_info *pi, bool *link_up);
+enum ice_status ice_update_link_info(struct ice_port_info *pi);
 enum ice_status
 ice_acquire_res(struct ice_hw *hw, enum ice_aq_res_ids res,
                enum ice_aq_res_access_type access, u32 timeout);
index 8a9301d2a68562ad97e713844b0f0df68b7f89b4..bb42ee643b77534ffb1cc7398ef4e34a25682bfd 100644 (file)
@@ -3219,6 +3219,10 @@ static void ice_rebuild(struct ice_pf *pf)
                goto err_vsi_rebuild;
        }
 
+       err = ice_update_link_info(hw->port_info);
+       if (err)
+               dev_err(&pf->pdev->dev, "Get link status error %d\n", err);
+
        /* Replay all VSIs Configuration, including filters after reset */
        if (ice_vsi_replay_all(pf)) {
                dev_err(&pf->pdev->dev,