]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dasd: remove dead code
authorJens Axboe <axboe@kernel.dk>
Thu, 25 Oct 2018 09:07:57 +0000 (11:07 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 7 Nov 2018 20:42:32 +0000 (13:42 -0700)
Since e443343e509a we haven't had a request_fn attached to
this driver, hence any code inside an if (q->request_fn) is
unreachable.

Fixes: e443343e509a ("s390/dasd: blk-mq conversion")
[sth: Keep and fix the dasd_info->chanq_len counter.]
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Tested-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/s390/block/dasd_ioctl.c

index 2016e0ed5865726011742227de740053d492b337..8e26001dc11c0df421c68e1ad323752e33af4922 100644 (file)
@@ -412,6 +412,7 @@ static int dasd_ioctl_information(struct dasd_block *block,
        struct ccw_dev_id dev_id;
        struct dasd_device *base;
        struct ccw_device *cdev;
+       struct list_head *l;
        unsigned long flags;
        int rc;
 
@@ -462,23 +463,10 @@ static int dasd_ioctl_information(struct dasd_block *block,
 
        memcpy(dasd_info->type, base->discipline->name, 4);
 
-       if (block->request_queue->request_fn) {
-               struct list_head *l;
-#ifdef DASD_EXTENDED_PROFILING
-               {
-                       struct list_head *l;
-                       spin_lock_irqsave(&block->lock, flags);
-                       list_for_each(l, &block->request_queue->queue_head)
-                               dasd_info->req_queue_len++;
-                       spin_unlock_irqrestore(&block->lock, flags);
-               }
-#endif                         /* DASD_EXTENDED_PROFILING */
-               spin_lock_irqsave(get_ccwdev_lock(base->cdev), flags);
-               list_for_each(l, &base->ccw_queue)
-                       dasd_info->chanq_len++;
-               spin_unlock_irqrestore(get_ccwdev_lock(base->cdev),
-                                      flags);
-       }
+       spin_lock_irqsave(&block->queue_lock, flags);
+       list_for_each(l, &base->ccw_queue)
+               dasd_info->chanq_len++;
+       spin_unlock_irqrestore(&block->queue_lock, flags);
 
        rc = 0;
        if (copy_to_user(argp, dasd_info,