]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PM / Domains: Fix compatible for domain idle state
authorLina Iyer <lina.iyer@linaro.org>
Thu, 3 Nov 2016 21:54:35 +0000 (14:54 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 6 Dec 2016 21:05:38 +0000 (22:05 +0100)
Re-using idle state definition provided by arm,idle-state for domain
idle states creates a lot of confusion and limits further evolution of
the domain idle definition. To keep things clear and simple, define a
idle states for domain using a new compatible "domain-idle-state".

Fix existing PM domains code to look for the newly defined compatible.

Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Documentation/devicetree/bindings/power/domain-idle-state.txt [new file with mode: 0644]
Documentation/devicetree/bindings/power/power_domain.txt
drivers/base/power/domain.c

diff --git a/Documentation/devicetree/bindings/power/domain-idle-state.txt b/Documentation/devicetree/bindings/power/domain-idle-state.txt
new file mode 100644 (file)
index 0000000..eefc7ed
--- /dev/null
@@ -0,0 +1,33 @@
+PM Domain Idle State Node:
+
+A domain idle state node represents the state parameters that will be used to
+select the state when there are no active components in the domain.
+
+The state node has the following parameters -
+
+- compatible:
+       Usage: Required
+       Value type: <string>
+       Definition: Must be "domain-idle-state".
+
+- entry-latency-us
+       Usage: Required
+       Value type: <prop-encoded-array>
+       Definition: u32 value representing worst case latency in
+                   microseconds required to enter the idle state.
+                   The exit-latency-us duration may be guaranteed
+                   only after entry-latency-us has passed.
+
+- exit-latency-us
+       Usage: Required
+       Value type: <prop-encoded-array>
+       Definition: u32 value representing worst case latency
+                   in microseconds required to exit the idle state.
+
+- min-residency-us
+       Usage: Required
+       Value type: <prop-encoded-array>
+       Definition: u32 value representing minimum residency duration
+                   in microseconds after which the idle state will yield
+                   power benefits after overcoming the overhead in entering
+i                  the idle state.
index e1650364b296359557196a4e502f2185295b24a3..723e1ad937da24edefa5c48b03ccb1f345c9919f 100644 (file)
@@ -31,7 +31,7 @@ Optional properties:
 
 - domain-idle-states : A phandle of an idle-state that shall be soaked into a
                 generic domain power state. The idle state definitions are
-                compatible with arm,idle-state specified in [1].
+                compatible with domain-idle-state specified in [1].
   The domain-idle-state property reflects the idle state of this PM domain and
   not the idle states of the devices or sub-domains in the PM domain. Devices
   and sub-domains have their own idle-states independent of the parent
@@ -85,7 +85,7 @@ Example 3:
        };
 
        DOMAIN_RET: state@0 {
-               compatible = "arm,idle-state";
+               compatible = "domain-idle-state";
                reg = <0x0>;
                entry-latency-us = <1000>;
                exit-latency-us = <2000>;
@@ -93,7 +93,7 @@ Example 3:
        };
 
        DOMAIN_PWR_DN: state@1 {
-               compatible = "arm,idle-state";
+               compatible = "domain-idle-state";
                reg = <0x1>;
                entry-latency-us = <5000>;
                exit-latency-us = <8000>;
@@ -118,4 +118,4 @@ The node above defines a typical PM domain consumer device, which is located
 inside a PM domain with index 0 of a power controller represented by a node
 with the label "power".
 
-[1]. Documentation/devicetree/bindings/arm/idle-states.txt
+[1]. Documentation/devicetree/bindings/power/domain-idle-state.txt
index 46e7f6052c9b36e8019040ccd372c7454a1aac1f..5711708532db12be9a7052a18d5b5ddc7e95d1a1 100644 (file)
@@ -2049,7 +2049,7 @@ int genpd_dev_pm_attach(struct device *dev)
 EXPORT_SYMBOL_GPL(genpd_dev_pm_attach);
 
 static const struct of_device_id idle_state_match[] = {
-       { .compatible = "arm,idle-state", },
+       { .compatible = "domain-idle-state", },
        { }
 };