]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: exfat: remove the redundant check when kfree an object in exfat_destroy_inode
authorzhong jiang <zhongjiang@huawei.com>
Wed, 4 Sep 2019 10:03:28 +0000 (18:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Sep 2019 17:14:46 +0000 (19:14 +0200)
kfree has taken the null check in account. hence it is unnecessary to add the
null check before kfree the object. Just remove it.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Link: https://lore.kernel.org/r/1567591408-24268-1-git-send-email-zhongjiang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/exfat/exfat_super.c

index 95bb606766b6b67534dddb041e963b18a1898dea..46ff33688c421f2238dc84f179ac18a5f62c83e7 100644 (file)
@@ -3498,8 +3498,7 @@ static struct inode *exfat_alloc_inode(struct super_block *sb)
 
 static void exfat_destroy_inode(struct inode *inode)
 {
-       if (EXFAT_I(inode)->target)
-               kfree(EXFAT_I(inode)->target);
+       kfree(EXFAT_I(inode)->target);
        EXFAT_I(inode)->target = NULL;
 
        kmem_cache_free(exfat_inode_cachep, EXFAT_I(inode));