]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
leds: tlc591xx: use devm_led_classdev_register_ext()
authorJean-Jacques Hiblot <jjhiblot@ti.com>
Fri, 20 Sep 2019 11:58:06 +0000 (13:58 +0200)
committerPavel <pavel@ucw.cz>
Sun, 3 Nov 2019 16:37:35 +0000 (17:37 +0100)
Use devm_led_classdev_register_ext() to pass the fwnode to the LED core.
The fwnode can then be used by the firmware core to create meaningful
names.

Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-tlc591xx.c

index bbdaa31483172c9178ad7ead8aabf5d20accaea2..8eadb673dc2e4965680745b2e9e35f24e8e5ce7f 100644 (file)
@@ -186,6 +186,9 @@ tlc591xx_probe(struct i2c_client *client,
 
        for_each_child_of_node(np, child) {
                struct tlc591xx_led *led;
+               struct led_init_data init_data = {};
+
+               init_data.fwnode = of_fwnode_handle(child);
 
                err = of_property_read_u32(child, "reg", &reg);
                if (err) {
@@ -200,8 +203,6 @@ tlc591xx_probe(struct i2c_client *client,
                led = &priv->leds[reg];
 
                led->active = true;
-               led->ldev.name =
-                       of_get_property(child, "label", NULL) ? : child->name;
                led->ldev.default_trigger =
                        of_get_property(child, "linux,default-trigger", NULL);
 
@@ -209,7 +210,8 @@ tlc591xx_probe(struct i2c_client *client,
                led->led_no = reg;
                led->ldev.brightness_set_blocking = tlc591xx_brightness_set;
                led->ldev.max_brightness = LED_FULL;
-               err = devm_led_classdev_register(dev, &led->ldev);
+               err = devm_led_classdev_register_ext(dev, &led->ldev,
+                                                    &init_data);
                if (err < 0) {
                        dev_err(dev, "couldn't register LED %s\n",
                                led->ldev.name);