]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: gadget: f_fs: use complete() instead complete_all()
authorDaniel Wagner <daniel.wagner@bmw-carit.de>
Thu, 22 Sep 2016 13:51:53 +0000 (15:51 +0200)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Thu, 3 Nov 2016 08:38:38 +0000 (10:38 +0200)
There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

waiter context                          waker context
  reinit_completion()
  usb_esp_queue()
  wait_for_completion_interruptible()

ffs_ep0_complete()
  complete()

Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Michal Nazarewicz <mina86@mina86.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/function/f_fs.c

index e40d47d47d82ad9afd7124ef3ab0151b6e6ecfa7..dff72a8732974f9f6ca9be457689a2a87a77e084 100644 (file)
@@ -266,7 +266,7 @@ static void ffs_ep0_complete(struct usb_ep *ep, struct usb_request *req)
 {
        struct ffs_data *ffs = req->context;
 
-       complete_all(&ffs->ep0req_completion);
+       complete(&ffs->ep0req_completion);
 }
 
 static int __ffs_ep0_queue_wait(struct ffs_data *ffs, char *data, size_t len)