fs/kernfs/dir.c: Clean code by removing always true condition

Previously there was an additional check if variable pos is not null.
However, this check happens after entering while loop and only then,
which can happen only if pos is not null.
Therefore the additional check is redundant and can be removed.

Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20191230191628.21099-1-mateusznosek0@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 9d96e6871e1ac5f9f8d126aed86af640aa9cc004..9aec80b9d7c6c6bd35fcd3c8ea8983c9463b27c3 100644 (file)
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -1266,7 +1266,7 @@ void kernfs_activate(struct kernfs_node *kn)
 
        pos = NULL;
        while ((pos = kernfs_next_descendant_post(pos, kn))) {
-               if (!pos || (pos->flags & KERNFS_ACTIVATED))
+               if (pos->flags & KERNFS_ACTIVATED)
                        continue;
 
                WARN_ON_ONCE(pos->parent && RB_EMPTY_NODE(&pos->rb));