]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: fix driver operation for 5350
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 21 Apr 2019 14:58:11 +0000 (17:58 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Sun, 28 Apr 2019 06:59:59 +0000 (09:59 +0300)
We introduced a bug that prevented this old device from
working. The driver would simply not be able to complete
the INIT flow while spewing this warning:

 CSR addresses aren't configured
 WARNING: CPU: 0 PID: 819 at drivers/net/wireless/intel/iwlwifi/pcie/drv.c:917
 iwl_pci_probe+0x160/0x1e0 [iwlwifi]

Cc: stable@vger.kernel.org # v4.18+
Fixes: a8cbb46f831d ("iwlwifi: allow different csr flags for different device families")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Fixes: c8f1b51e506d ("iwlwifi: allow different csr flags for different device families")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/cfg/5000.c

index 575a7022d045be7ad37243b1ae4c454efebd24dc..3846064d51a5a7c14ba866070a14b5802474a73b 100644 (file)
@@ -1,7 +1,7 @@
 /******************************************************************************
  *
  * Copyright(c) 2007 - 2014 Intel Corporation. All rights reserved.
- * Copyright(c) 2018 Intel Corporation
+ * Copyright(c) 2018 - 2019 Intel Corporation
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of version 2 of the GNU General Public License as
@@ -136,6 +136,7 @@ const struct iwl_cfg iwl5350_agn_cfg = {
        .ht_params = &iwl5000_ht_params,
        .led_mode = IWL_LED_BLINK,
        .internal_wimax_coex = true,
+       .csr = &iwl_csr_v1,
 };
 
 #define IWL_DEVICE_5150                                                \