]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] radio-bcm2048: fix wrong overflow check
authorPali Rohár <pali.rohar@gmail.com>
Tue, 22 Apr 2014 15:02:39 +0000 (12:02 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 23 May 2014 15:17:21 +0000 (12:17 -0300)
This patch fixes an off by one check in bcm2048_set_region().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/staging/media/bcm2048/radio-bcm2048.c

index b2cd3a85166d7477610115b4c026cf69079baadf..bbf236e842a99f005a6f8e802d5c71f49c66b22d 100644 (file)
@@ -737,7 +737,7 @@ static int bcm2048_set_region(struct bcm2048_device *bdev, u8 region)
        int err;
        u32 new_frequency = 0;
 
-       if (region > ARRAY_SIZE(region_configs))
+       if (region >= ARRAY_SIZE(region_configs))
                return -EINVAL;
 
        mutex_lock(&bdev->mutex);