]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
remoteproc/davinci: drop needless devm_clk_put
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 23 Sep 2013 16:00:20 +0000 (18:00 +0200)
committerOhad Ben-Cohen <ohad@wizery.com>
Mon, 24 Feb 2014 09:00:55 +0000 (11:00 +0200)
The comment above disable_irq says that it is needed to ensure that the
"devm subsystem might end up releasing things before freeing the irq,
thus allowing an interrupt to sneak in while the device is being
removed." disable_irq is enough for this purpose and there is no need to
manually free the reference to the clock.

Cc: Robert Tivy <rtivy@ti.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
[moved the Cc line into the commit message]
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
drivers/remoteproc/da8xx_remoteproc.c

index 129f7b9978663b159e16c30e30e3ec590656a3f0..b91cd3086fb71c273059a787f69aae7d7fd25304 100644 (file)
@@ -301,8 +301,6 @@ static int da8xx_rproc_remove(struct platform_device *pdev)
         */
        disable_irq(drproc->irq);
 
-       devm_clk_put(dev, drproc->dsp_clk);
-
        rproc_del(rproc);
        rproc_put(rproc);