]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
watchdog: sama5d4: Add comment explaining what happens on resume
authorAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 2 Mar 2017 17:31:14 +0000 (18:31 +0100)
committerWim Van Sebroeck <wim@iguana.be>
Mon, 5 Jun 2017 15:58:39 +0000 (17:58 +0200)
Because suspending to RAM may lose the register values, they are restored
on resume. This is currently done unconditionally because there is
currently no way to know (from the driver) whether they have really been
lost or are still valid. Writing MR also pings the watchdog and this may
not be what is expected so add a comment explaining why it happens.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/sama5d4_wdt.c

index d710014f3b7d5b6f5cefa72037415d5725fd66e9..0ae947c3d7bcb10a1e8caae89b065e5bdf1de45f 100644 (file)
@@ -300,6 +300,11 @@ static int sama5d4_wdt_resume(struct device *dev)
 {
        struct sama5d4_wdt *wdt = dev_get_drvdata(dev);
 
+       /*
+        * FIXME: writing MR also pings the watchdog which may not be desired.
+        * This should only be done when the registers are lost on suspend but
+        * there is no way to get this information right now.
+        */
        sama5d4_wdt_init(wdt);
 
        return 0;