]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: au0828: use signals instead of hardcoding a pad number
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 1 Aug 2018 09:36:15 +0000 (05:36 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 17 Sep 2018 17:16:19 +0000 (13:16 -0400)
When creating the audio link, use pad signals, instead of
hardcoding using the pad index number.

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/au0828/au0828-core.c

index cd363a2100d453c6b5be15b35430907acd44cdde..4729b2a2f21c34e5c535f806627592de029c9602 100644 (file)
@@ -266,11 +266,13 @@ static void au0828_media_graph_notify(struct media_entity *new,
 
 create_link:
        if (decoder && mixer) {
-               ret = media_create_pad_link(decoder,
-                                           DEMOD_PAD_AUDIO_OUT,
-                                           mixer, 0,
-                                           MEDIA_LNK_FL_ENABLED);
-               if (ret)
+               ret = media_get_pad_index(decoder, false,
+                                         PAD_SIGNAL_AUDIO);
+               if (ret >= 0)
+                       ret = media_create_pad_link(decoder, ret,
+                                                   mixer, 0,
+                                                   MEDIA_LNK_FL_ENABLED);
+               if (ret < 0)
                        dev_err(&dev->usbdev->dev,
                                "Mixer Pad Link Create Error: %d\n", ret);
        }