]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
RDMA/ocrdma: Remove unsupported modify_port callback
authorKamal Heib <kamalheib1@gmail.com>
Mon, 28 Oct 2019 15:59:30 +0000 (17:59 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 6 Nov 2019 17:29:15 +0000 (13:29 -0400)
There is no need to return always zero for function which is not
supported.

Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
Link: https://lore.kernel.org/r/20191028155931.1114-4-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/ocrdma/ocrdma_main.c
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
drivers/infiniband/hw/ocrdma/ocrdma_verbs.h

index c15cfc6cef81ac2850804e595fb06775e7d671ae..d8c47d24d6d66bee21900962f2181a20403c5b7f 100644 (file)
@@ -166,7 +166,6 @@ static const struct ib_device_ops ocrdma_dev_ops = {
        .get_port_immutable = ocrdma_port_immutable,
        .map_mr_sg = ocrdma_map_mr_sg,
        .mmap = ocrdma_mmap,
-       .modify_port = ocrdma_modify_port,
        .modify_qp = ocrdma_modify_qp,
        .poll_cq = ocrdma_poll_cq,
        .post_recv = ocrdma_post_recv,
index e8267e59077226ff8758539eaa3c21a9575634f7..e72050de573415dad2c450a1e2190f65b438d8bc 100644 (file)
@@ -190,12 +190,6 @@ int ocrdma_query_port(struct ib_device *ibdev,
        return 0;
 }
 
-int ocrdma_modify_port(struct ib_device *ibdev, u8 port, int mask,
-                      struct ib_port_modify *props)
-{
-       return 0;
-}
-
 static int ocrdma_add_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr,
                           unsigned long len)
 {
index 32488da1b7520f16eb934739ee99c10723553a18..3a5010881be5b877d936f22e016851d97b905988 100644 (file)
@@ -54,8 +54,6 @@ int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags);
 int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props,
                        struct ib_udata *uhw);
 int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props);
-int ocrdma_modify_port(struct ib_device *, u8 port, int mask,
-                      struct ib_port_modify *props);
 
 enum rdma_protocol_type
 ocrdma_query_protocol(struct ib_device *device, u8 port_num);