]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
audit: drop audit_log_abend()
authorPaul Davies C <pauldaviesc@gmail.com>
Fri, 8 Nov 2013 04:27:39 +0000 (09:57 +0530)
committerEric Paris <eparis@redhat.com>
Tue, 14 Jan 2014 03:30:59 +0000 (22:30 -0500)
The audit_log_abend() is used only by the audit_core_dumps(). Thus there is no
need of maintaining the audit_log_abend() as a separate function.

This patch drops the audit_log_abend() and pushes its functionalities back to
the audit_core_dumps(). Apart from that the "reason" field is also dropped
from being logged since the reason can be deduced from the signal number.

Signed-off-by: Paul Davies C <pauldaviesc@gmail.com>
Acked-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
kernel/auditsc.c

index 9ab02fa2334ce5b7975f03c772804b4c4eb5da1a..fc3b3dbcc8aa7582945770f7e7f5d2b83ef4bcc0 100644 (file)
@@ -2368,13 +2368,6 @@ static void audit_log_task(struct audit_buffer *ab)
        audit_log_untrustedstring(ab, current->comm);
 }
 
-static void audit_log_abend(struct audit_buffer *ab, char *reason, long signr)
-{
-       audit_log_task(ab);
-       audit_log_format(ab, " reason=");
-       audit_log_string(ab, reason);
-       audit_log_format(ab, " sig=%ld", signr);
-}
 /**
  * audit_core_dumps - record information about processes that end abnormally
  * @signr: signal value
@@ -2395,7 +2388,8 @@ void audit_core_dumps(long signr)
        ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_ANOM_ABEND);
        if (unlikely(!ab))
                return;
-       audit_log_abend(ab, "memory violation", signr);
+       audit_log_task(ab);
+       audit_log_format(ab, " sig=%ld", signr);
        audit_log_end(ab);
 }