]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: s5k4ecgx: delete a bogus error message
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 15 Jan 2019 19:54:54 +0000 (17:54 -0200)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 25 Jan 2019 13:01:42 +0000 (11:01 -0200)
This function prints an error message on success.  I don't have the
hardware, I just noticed this while reading the code.

Fixes: 8b99312b7214 ("[media] Add v4l2 subdev driver for S5K4ECGX sensor")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/s5k4ecgx.c

index 79aa2740edc471beb8d741695000e1ded03a2a16..79c1894c2c83d2ee6c642c0e3128bd5c19ff6d2a 100644 (file)
@@ -263,8 +263,6 @@ static int s5k4ecgx_read(struct i2c_client *client, u32 addr, u16 *val)
                ret = s5k4ecgx_i2c_write(client, REG_CMDRD_ADDRL, low);
        if (!ret)
                ret = s5k4ecgx_i2c_read(client, REG_CMDBUF0_ADDR, val);
-       if (!ret)
-               dev_err(&client->dev, "Failed to execute read command\n");
 
        return ret;
 }