]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
m68k/irq: Prepare irq handlers for irq argument removal
authorThomas Gleixner <tglx@linutronix.de>
Fri, 31 Jul 2015 19:56:10 +0000 (21:56 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sat, 1 Aug 2015 06:07:22 +0000 (08:07 +0200)
The irq argument of most interrupt flow handlers is unused or merily
used instead of a local variable. The handlers which need the irq
argument can retrieve the irq number from the irq descriptor.

Search and update was done with coccinelle and the invaluable help of
Julia Lawall.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
arch/m68k/coldfire/intc-5272.c
arch/m68k/mac/oss.c
arch/m68k/mac/psc.c

index d1e2fbad327cecaa4c785e4b270177a6c030cbb5..47371de60427bd61b4d8c0f6abb6f5de95978c80 100644 (file)
@@ -143,8 +143,10 @@ static int intc_irq_set_type(struct irq_data *d, unsigned int type)
  * We need to be careful with the masking/acking due to the side effects
  * of masking an interrupt.
  */
-static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
+static void intc_external_irq(unsigned int __irq, struct irq_desc *desc)
 {
+       unsigned int irq = irq_desc_get_irq(desc);
+
        irq_desc_get_chip(desc)->irq_ack(&desc->irq_data);
        handle_simple_irq(irq, desc);
 }
index bb11dceed7ed2e947ea31f9393539c8b2e6f5c41..191610d97689932ba8413af2ccc27b77e3addc9f 100644 (file)
@@ -63,13 +63,15 @@ void __init oss_nubus_init(void)
  * Handle miscellaneous OSS interrupts.
  */
 
-static void oss_irq(unsigned int irq, struct irq_desc *desc)
+static void oss_irq(unsigned int __irq, struct irq_desc *desc)
 {
        int events = oss->irq_pending &
-                    (OSS_IP_IOPSCC | OSS_IP_SCSI | OSS_IP_IOPISM);
+               (OSS_IP_IOPSCC | OSS_IP_SCSI | OSS_IP_IOPISM);
 
 #ifdef DEBUG_IRQS
        if ((console_loglevel == 10) && !(events & OSS_IP_SCSI)) {
+               unsigned int irq = irq_desc_get_irq(desc);
+
                printk("oss_irq: irq %u events = 0x%04X\n", irq,
                        (int) oss->irq_pending);
        }
index 272dde481d170e815d740d0880ae613c3567cca8..3b9e302e7a37f5fa80336bca8f5af07e131b5fbc 100644 (file)
@@ -113,9 +113,10 @@ void __init psc_init(void)
  * PSC interrupt handler. It's a lot like the VIA interrupt handler.
  */
 
-static void psc_irq(unsigned int irq, struct irq_desc *desc)
+static void psc_irq(unsigned int __irq, struct irq_desc *desc)
 {
        unsigned int offset = (unsigned int)irq_desc_get_handler_data(desc);
+       unsigned int irq = irq_desc_get_irq(desc);
        int pIFR        = pIFRbase + offset;
        int pIER        = pIERbase + offset;
        int irq_num;