]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: lustre: obdecho: remove unneeded null test before free
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 1 May 2015 19:37:51 +0000 (21:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 May 2015 07:23:55 +0000 (09:23 +0200)
Kfree can cope with a null argument, so drop null tests.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression ptr; @@

- if (ptr != NULL)
  kfree(ptr);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/obdecho/echo_client.c

index cf645388dc7583ded216f3075a9cf2cf8d54683f..53761787a56f1219370e99654e8a74a3f71f7452 100644 (file)
@@ -1737,10 +1737,8 @@ static int echo_client_prep_commit(const struct lu_env *env,
        }
 
 out:
-       if (lnb)
-               kfree(lnb);
-       if (rnb)
-               kfree(rnb);
+       kfree(lnb);
+       kfree(rnb);
        return ret;
 }