]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
tools/bpf: add missing strings.h include
authorAndrii Nakryiko <andriin@fb.com>
Thu, 7 Feb 2019 19:29:24 +0000 (11:29 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 8 Feb 2019 02:18:42 +0000 (18:18 -0800)
Few files in libbpf are using bzero() function (defined in strings.h header), but
don't include corresponding header. When libbpf is added as a dependency to pahole,
this undeterministically causes warnings on some machines:

bpf.c:225:2: warning: implicit declaration of function 'bzero' [-Wimplicit-function-declaration]
  bzero(&attr, sizeof(attr));
    ^~~~~

Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/lib/bpf/bpf.c
tools/lib/bpf/btf.c
tools/lib/bpf/libbpf.c

index 3defad77dc7aca37e7496e2aee6e6b386f44a802..92fd27fe0599b1a2f081e9a285d18fbb599034e7 100644 (file)
@@ -22,6 +22,7 @@
  */
 
 #include <stdlib.h>
+#include <strings.h>
 #include <memory.h>
 #include <unistd.h>
 #include <asm/unistd.h>
index ab6528c935a1005c1a22afa2cf3c958ad0cffe27..4324eb47d214bcd43c10cebc08f3010bb65ad6d3 100644 (file)
@@ -4,6 +4,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <strings.h>
 #include <unistd.h>
 #include <errno.h>
 #include <linux/err.h>
index 47969aa0faf80733ab2f05fb9ef5ea9b09b1681e..8d64ada5f7284b3bcc929c2b2066631c85f39da5 100644 (file)
@@ -18,6 +18,7 @@
 #include <libgen.h>
 #include <inttypes.h>
 #include <string.h>
+#include <strings.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <errno.h>