]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] af9013: cancel_delayed_work_sync before device removal / kfree
authorErnst Martin Witte <emw-linux-kernel@nocabal.de>
Sat, 9 Jan 2016 20:18:45 +0000 (18:18 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 1 Feb 2016 11:40:18 +0000 (09:40 -0200)
af9013_remove  was calling  kfree(state)  with  possibly still  active
schedule_delayed_work(&state->statistics_work).   A   similar  bug  in
si2157 caused kernel panics in call_timer_fn e.g. after rmmod cx23885.

Signed-off-by: Ernst Martin Witte <emw-linux-kernel@nocabal.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/af9013.c

index e23197da84af51bc244772d2dc2e7b01caf8eae9..41ab5defb7989b058bb42dfa90ecd972ded4381d 100644 (file)
@@ -1344,6 +1344,10 @@ static int af9013_i2c_gate_ctrl(struct dvb_frontend *fe, int enable)
 static void af9013_release(struct dvb_frontend *fe)
 {
        struct af9013_state *state = fe->demodulator_priv;
+
+       /* stop statistics polling */
+       cancel_delayed_work_sync(&state->statistics_work);
+
        kfree(state);
 }